fix(NODE-4467): Add back support for oplogReplay option as deprecated#3337
Merged
dariakp merged 2 commits intomongodb:mainfrom Aug 1, 2022
Merged
fix(NODE-4467): Add back support for oplogReplay option as deprecated#3337dariakp merged 2 commits intomongodb:mainfrom
oplogReplay option as deprecated#3337dariakp merged 2 commits intomongodb:mainfrom
Conversation
The option has been deprecated for MongoDB >=4.4 but should still be available to MongoDB <=4.2
durran
added
tracked-in-jira
durran
requested changes
Jul 28, 2022
Member
durran
left a comment
durran
left a comment
There was a problem hiding this comment.
Thanks @sampaiodiego for the PR! Could you add a unit test similar to the other operation constructor tests (example: https://github.com/mongodb/node-mongodb-native/blob/main/test/unit/operations/aggregate.test.js) so have a test to avoid another regression?
Contributor
Author
|
sure thing @durran .. I've added a few tests, let me know if that's good enough.. thx |
durran
approved these changes
Jul 29, 2022
durran
added
Team Review
nbbeeken
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The option has been deprecated for MongoDB >=4.4 but should still be available to MongoDB <=4.2
What is changing?
Oplog tailing for MongoDB server <=4.2 can still use this flag in order to have a better performance.
Is there new documentation needed for these changes?
No
What is the motivation for this change?
The initial query to tail the oplog on huge MongoDB 4.2 servers was taking too long to complete.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>